update for support of CMEK for vertex ai resource #6460

googlerjk · 2022-08-25T03:50:47Z

Added support to CMEK to vertexai resource featurestore.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertexai: added `encryption_spec` field to `google_vertex_ai_featurestore` resource (beta)

modular-magician · 2022-08-25T04:02:20Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 20 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 9 files changed, 101 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 2 files changed, 6 insertions(+))

modular-magician · 2022-08-25T04:54:01Z

Tests analytics

Total tests: 2144
Passed tests 1900
Skipped tests: 230
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccCloudRunService_cloudRunServiceScheduledExample|TestAccCGCSnippet_storageObjectLifecycleSettingExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

modular-magician · 2022-08-25T05:01:28Z

Tests passed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]

Tests failed during RECORDING mode:
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccCloudRunService_cloudRunServiceScheduledExample[view]
TestAccCGCSnippet_storageObjectLifecycleSettingExample[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-08-25T08:26:34Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 20 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 9 files changed, 101 insertions(+), 14 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-25T08:59:20Z

Tests analytics

Total tests: 2144
Passed tests 1900
Skipped tests: 230
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudRunService_cloudRunServiceScheduledExample|TestAccCGCSnippet_storageObjectLifecycleSettingExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample

modular-magician · 2022-08-25T09:15:29Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]
TestAccCloudRunService_cloudRunServiceScheduledExample[view]
TestAccCGCSnippet_storageObjectLifecycleSettingExample[view]
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn · 2022-08-25T19:47:19Z

re-rolling the reviewer, as I need to catch up on other reviews so I won't be able to get to this one in a while.
Couple things I noticed already though @googlerjk

Set the PR out of draft mode when you want someone to review
Add the service to the release note

modular-magician · 2022-08-26T07:16:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 66 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 9 files changed, 199 insertions(+), 16 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-26T08:13:24Z

Tests analytics

Total tests: 2146
Passed tests 1903
Skipped tests: 232
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

modular-magician · 2022-08-26T08:20:25Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccCloudFunctions2Function_fullUpdate[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-08-27T00:30:56Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 50 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 9 files changed, 167 insertions(+), 16 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-27T01:20:30Z

Tests analytics

Total tests: 2147
Passed tests 1905
Skipped tests: 233
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

modular-magician · 2022-08-27T01:35:50Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Tests failed during RECORDING mode:
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Looks like the tests failed due to not having provider = google-beta in the configuration, as this is a beta-only resource.
Plus, would you mind modifying the release note a bit based on the enhancements example here

modular-magician · 2022-08-29T19:31:13Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 57 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 9 files changed, 181 insertions(+), 22 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-29T19:42:16Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 54 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 9 files changed, 175 insertions(+), 16 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-29T20:28:20Z

Tests analytics

Total tests: 2151
Passed tests 1909
Skipped tests: 233
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing

modular-magician · 2022-08-29T20:49:07Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-08-30T01:14:13Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 20 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 9 files changed, 109 insertions(+), 16 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-08-30T02:04:57Z

Tests analytics

Total tests: 2151
Passed tests 1909
Skipped tests: 233
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-08-30T02:11:55Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1 · 2022-08-30T18:01:51Z

@googlerjk I modified the changelog a bit, please let me know if that makes sense:

changed service name from vertex_ai to vertexai
added beta label at the end as google_vertex_ai_featurestore is a beta-only resource, so the change only affects beta provider and we only want include this changelog in the beta provider release.

shuyama1

LGTM! Thanks!

…m#6460) * update for support of CMEK for vertex ai resource * kms key as a resource added * Bootstrapped kms-key-name

googlerjk requested a review from c2thorn August 25, 2022 03:50

update for support of CMEK for vertex ai resource

d390b75

googlerjk force-pushed the jk-vertex_ai_CMEK-support branch from e4a4354 to d390b75 Compare August 25, 2022 08:15

c2thorn requested review from a team and shuyama1 and removed request for c2thorn and a team August 25, 2022 19:44

googlerjk marked this pull request as ready for review August 26, 2022 06:37

googlerjk force-pushed the jk-vertex_ai_CMEK-support branch from 6801b70 to 416ee91 Compare August 27, 2022 00:19

shuyama1 reviewed Aug 29, 2022

View reviewed changes

googlerjk force-pushed the jk-vertex_ai_CMEK-support branch from 416ee91 to dae6c7b Compare August 29, 2022 19:19

modular-magician requested a review from shuyama1 August 29, 2022 19:20

kms key as a resource added

c51bad0

googlerjk force-pushed the jk-vertex_ai_CMEK-support branch from dae6c7b to c51bad0 Compare August 29, 2022 19:31

Bootstrapped kms-key-name

87ad2c9

shuyama1 approved these changes Aug 30, 2022

View reviewed changes

googlerjk merged commit 510393b into GoogleCloudPlatform:main Aug 30, 2022

sanghaniJ mentioned this pull request Dec 28, 2022

Add CMEK support for google_vertex_ai_featurestore hashicorp/terraform-provider-google#11721

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update for support of CMEK for vertex ai resource #6460

update for support of CMEK for vertex ai resource #6460

googlerjk commented Aug 25, 2022 •

edited by shuyama1

Loading

modular-magician commented Aug 25, 2022

modular-magician commented Aug 25, 2022

modular-magician commented Aug 25, 2022

modular-magician commented Aug 25, 2022

modular-magician commented Aug 25, 2022

modular-magician commented Aug 25, 2022

c2thorn commented Aug 25, 2022

modular-magician commented Aug 26, 2022

modular-magician commented Aug 26, 2022

modular-magician commented Aug 26, 2022

modular-magician commented Aug 27, 2022

modular-magician commented Aug 27, 2022

modular-magician commented Aug 27, 2022

shuyama1 left a comment

modular-magician commented Aug 29, 2022

modular-magician commented Aug 29, 2022

modular-magician commented Aug 29, 2022

modular-magician commented Aug 29, 2022

modular-magician commented Aug 30, 2022

modular-magician commented Aug 30, 2022

modular-magician commented Aug 30, 2022

shuyama1 commented Aug 30, 2022

shuyama1 left a comment

update for support of CMEK for vertex ai resource #6460

update for support of CMEK for vertex ai resource #6460

Conversation

googlerjk commented Aug 25, 2022 • edited by shuyama1 Loading

modular-magician commented Aug 25, 2022

Diff report:

modular-magician commented Aug 25, 2022

Tests analytics

Action taken

modular-magician commented Aug 25, 2022

modular-magician commented Aug 25, 2022

Diff report:

modular-magician commented Aug 25, 2022

Tests analytics

Action taken

modular-magician commented Aug 25, 2022

c2thorn commented Aug 25, 2022

modular-magician commented Aug 26, 2022

Diff report:

modular-magician commented Aug 26, 2022

Tests analytics

Action taken

modular-magician commented Aug 26, 2022

modular-magician commented Aug 27, 2022

Diff report:

modular-magician commented Aug 27, 2022

Tests analytics

Action taken

modular-magician commented Aug 27, 2022

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 29, 2022

Diff report:

modular-magician commented Aug 29, 2022

Diff report:

modular-magician commented Aug 29, 2022

Tests analytics

Action taken

modular-magician commented Aug 29, 2022

modular-magician commented Aug 30, 2022

Diff report:

modular-magician commented Aug 30, 2022

Tests analytics

Action taken

modular-magician commented Aug 30, 2022

shuyama1 commented Aug 30, 2022

shuyama1 left a comment

Choose a reason for hiding this comment

googlerjk commented Aug 25, 2022 •

edited by shuyama1

Loading